fix(gltf, converter): make ext-mesh-features independent from ext-structural-metadata #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mspivak-actionengine
commented
Sep 21, 2023
•
mspivak-actionengine
commented
- ext-mesh-features is being handled independently from the ext-structural-metadata
- fix of incorrect getting data for texture attributes
- docs for functions improved
- fix comments on previous pr
- test for ext-mesh-features added
…uctural-metadata. Fix comments on prev pr
dsavinov-actionengine
added
the
ActionEngine
dsavinov-actionengine
changed the title
Merge the fix of build issues
ibgreen
approved these changes
Sep 21, 2023
| @@ -285,7 +288,7 @@ function getImageValueByCoordinates( | |||
| let value: number = 0; | |||
| for (const c of channels) { | |||
| // We can get the element of CHANNELS_MAP by either index (0, 1, 2, 3) or key (r, g, b, a) | |||
| const map = typeof c === "number" ? Object.values(CHANNELS_MAP)[c] : CHANNELS_MAP[c]; | |||
| const map = typeof c === 'number' ? Object.values(CHANNELS_MAP)[c] : CHANNELS_MAP[c]; | |||
There was a problem hiding this comment.
This type of indexing is messy, is it unavoidable or can we rewrite? I.e. is it mandated by the specs?
There was a problem hiding this comment.
According to the EXT_feature_metadata extension specification:
Channels are labeled by rgba and are swizzled with a string of 1-4 characters.
According to the EXT_mesh_features extension specification:
The channels array contains non-negative integer values corresponding to channels of the source texture that the feature ID consists of.
Channels of an RGBA texture are numbered 0–3 respectively.
Function getImageValueByCoordinates is used to process both extensions.
So, there should be possible to get the element of CHANNELS_MAP by either index (0, 1, 2, 3) or key (r, g, b, a).
I added the comment to the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.